-
Notifications
You must be signed in to change notification settings - Fork 2.8k
🐛 Fix glitchy kangaroo bounce animation on welcome screen #10035
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 Fix glitchy kangaroo bounce animation on welcome screen #10035
Conversation
Review complete. No issues found. The fix correctly addresses the animation glitch by using a custom keyframe animation that explicitly starts from Mention @roomote in a comment to request specific changes to this pull request or fix all unresolved issues. |
|
I love the dedication here. Thanks for doing what I was too lazy to do 🙏 |
|
Happy to tweak minor stuff. It was fun jumping into the code. 🦘🦘 |
|
@roomote Please run PR Fixer mode on this PR. |
Resolved merge conflicts by merging main and preserving the smooth-bounce animation fix. All local checks passed. |
Resolved merge conflicts by rebasing onto main. All local checks passed. |
The kangaroo logo on the welcome screen had a visual glitch where it would instantly jump to the top position when hovering, instead of smoothly starting the bounce from its resting position. Changes: - Added custom smooth-bounce keyframe animation in index.css that explicitly starts from translateY(0) - Updated RooHero component to use hover state tracking with the new animation - Removed Tailwind's animate-bounce class which was causing the glitch The animation now smoothly bounces from the resting position without any jarring visual jumps.
7dc65d8 to
dc9fbc3
Compare
Description
Fixes the visual glitch where the kangaroo logo on the welcome screen would instantly jump to the top position when hovering, instead of smoothly starting the bounce from its resting position.
Changes
Testing
The kangaroo now smoothly bounces from the resting position without any jarring visual jumps when hovering over it on the welcome screen.
Screenshots/Videos
The animation now starts smoothly from the resting position instead of jumping to the top first.
Checklist
Important
Fixes kangaroo bounce animation glitch on welcome screen by adding custom keyframe animation and hover state tracking in
RooHero.tsx.group-hover:animate-bounceclass causing the glitch inRooHero.tsx.smooth-bouncekeyframe animation toindex.cssfor smooth hover effect.smooth-bounceanimation inRooHero.tsxbased on hover state.isHoveredstate inRooHero.tsxto track hover status and trigger animation.This description was created by
for 7dc65d8. You can customize this summary. It will automatically update as commits are pushed.